[Ns-developers] LENA code review request: lte + antenna + buildings + other modules

Nicola Baldo nbaldo at cttc.es
Mon Mar 5 10:31:11 PST 2012


Hi all,

I'd like to request an additional review of the the review of some code 
produced by CTTC within the LENA project for a potential inclusion in 
ns-3-dev:

1) the revised LTE module:
http://codereview.appspot.com/4626069/#ps31002
the same issue was submitted some time ago and kindly reviewd by 
Giuseppe. The new patch addresses Giuseppe's comments and also includes 
our latests LTE module features.
The corresponding documentation can be browsed here:
http://lena.cttc.es/manual/

2) the antenna module:
http://codereview.appspot.com/5726045/
This is the module previously discussed on ns-developers. The LTE module 
depends on it.
The corresponding documentation can be browsed here:
http://lena.cttc.es/antenna/

3) the buildings module:
http://codereview.appspot.com/5728062/
This is a new module that we developed to simulate the presence of 
buildings and its effect on propagation. Some examples included in the 
LTE module depend on it.
The corresponding documentation can be browsed here:
http://lena.cttc.es/buildings/

4) some other modifications belonging to other modules. I've uploaded 
them as a single patch here:
http://codereview.appspot.com/5731045/
Most of the above has already been previously submitted for review. In 
particular:
4a) the modifications in src/core, src/config-store and utils have been 
previously submitted by Jaume Nin as bug 1352:
https://www.nsnam.org/bugzilla/show_bug.cgi?id=1352
4b) the modifications in src/network have been previously submitted as 
bug 1238:
https://www.nsnam.org/bugzilla/show_bug.cgi?id=1283
4c) the remaining modifications are proposed in order to include the 
documentation of the above modules in the ns-3 models library documentation.


Any feedback would be very much appreciated!

Kind regards,


Nicola



More information about the Ns-developers mailing list