[Ns-developers] Starting to add code to ns-3

Daniel Halperin dhalperi at cs.washington.edu
Thu Sep 15 13:56:06 PDT 2011


Hi,

I have worked a project forked from ns-3.9 stable, and the code is now ready
"enough" that I'm starting to port it to ns-3-dev. To get started, I put my
first, relatively trivial preliminary patch up on rietveld and I think cc'ed
ns-3-reviews properly with upload.py.

http://codereview.appspot.com/5032043/

(0) So far, so good? The ns-3-dev contribution process is pretty convoluted
(way harder than the Linux Kernel, for instance!), so I'm not sure I'm
remotely close to following the right steps. I didn't see any patch comment
style guide, so I just used Linux Kernel style.

(1) I think I updated the python bindings properly, although I had to
manually grep **/*.py for code that used the module and then run ./waf
--apiscan=<module> for each result. --python-rescan did *not* detect changes
in the type signatures of the relevant functions. Is there a better way?

(2) What other feedback?

Thanks,
Dan


More information about the Ns-developers mailing list