[Ns-developers] Ipv6Extension (was UDPv6, missleading subject)

[Fabian Mauchle]

Hi,

I did that because Ipv6Extensios and Ipv6Options are currently treated
independently, which they aren’t. 

So my changes are:
- Add a relationship between Ipv6ExtensionHeader and Ipv6OptionHeader, with
the possibility to add Option headers to Extension Headers. This also
automates the Header alignment required by IPv6. (I implemented this some
time ago, based on the old IPv6 repo from Sebastien)

- Because options are often used to store additional information for
processing extensions, the independent processing of options does not suit
this very well. So I replaced the Ipv6OptionDemux by a list of Callbacks,
registered by the Ipv6Extension and called for each Ipv6OptionHeader present
(identified by the type field).

Regards,
Fabian


-----Ursprüngliche Nachricht-----
Von: ns-developers-bounces at ISI.EDU [mailto:ns-developers-bounces at ISI.EDU] Im
Auftrag von Faker Moatamri
Gesendet: Donnerstag, 29. Oktober 2009 11:36
An: vincent at clarinet.u-strasbg.fr
Cc: ns-developers at ISI.EDU; ns-3-reviews at googlegroups.com
Betreff: Re: [Ns-developers] UDPv6

Sébastien Vincent wrote:
> Hi,
>
> Tom Henderson a écrit :
>> Fabian Mauchle wrote:
>>> Hi Sebastien, Hi all,
>>>
>>> As we are heading on with merging more of Ipv6, I just wondered 
>>> about UDPv6.
>>> What is the current state of this, and will it be included in ns3.7?
>>
>> Fabian, this is the most recent update that has been on the list, and 
>> I'm not aware of any recent change:
>> http://mailman.isi.edu/pipermail/ns-developers/2009-July/006211.html
>>
>
> I have not started anything on UDP/TCP refactoring and I'm affraid I 
> will not have time to work on it until december/january.
> I prefer to take my little free time for merge IPv6 extension in
> ns-3.7 (available at https://svnet.u-strasbg.fr/hg/ns-3-ipv6-ext).
>
I prepared a patch based on the above repository which is included in the
mail.
I also uploaded the code change in Rietveld so it is easier to review: 
http://codereview.appspot.com/144048
I will be reviewing the code very soon. Tom, Craig, can you give a quick
review to the code?
Anyone else can review the code?

> Fabian has proposed to remove "IPv6 option demux" design from above 
> source tree. His repository is located at 
> http://sinv-56031.edu.hsr.ch/hg/ns-3-ipv6-ext. So feel free to review 
> these repositories and give feedback about the two solutions.
Is there any reason why he did that? reviewing the first code is enough
right?
Best regards
Faker Moatamri