[Ns-developers] Bug 622 review result and merge to ns-3-dev
craigdo at ee.washington.edu
Fri Oct 23 10:19:34 PDT 2009
> Hi Antti and All,
> I've been through the patch proposed for bug 622. This patch makes it
> possible to have comprehensive names of pcap files.
> I have been through this patch and I think small coding style stuff has
> to be fixed:
> -Coding style (space after parentheses, space before and after != & =
> Other than that +1 for patch to be added to ns-3-dev. It already got +1
> from Tom.
> Anyone has comments about the patch?
This patch only adds names support to the csma and point-to-point helpers.
If it were added as-is it would make the trace-enabled helpers inconsistent
for no particular reason. This is bad.
For consistency, this needs to be extended to all helpers that generate
trace files -- not just two.
There is already lots of code duplicated across the helpers. Adding names
support this way is going to make it worse. It's time to break this cycle.
For a number of reasons, I think we factor the implementation of the current
common functionality. We can then implement object names support once,
consistently, across the helpers, and remove all of the almost identical
code spread across many of the helpers.
I think it should actually be more difficult to implement this
inconsistently across helpers than consistently using a common class.
I volunteer to make the required changes and write the (cough)
More information about the Ns-developers