[Ns-developers] Bug 602 status

[Mirko Banchi]

Il giorno 23/ott/09, alle ore 12:00, Kirill Andreev ha scritto:
>
> Hi!, in addition to said above, could you, please, fix this  
> copy&paste in WifiRemoteStationManager class:
>
> TracedValue<uint32_t> m_ssrc;
> TracedValue<uint32_t> m_slrc;
> /* voice access class retry counters */
> TracedValue<uint32_t> m_voSsrc;
> TracedValue<uint32_t> m_voSlrc;
> /* video access class retry counters */
> TracedValue<uint32_t> m_viSsrc;
> TracedValue<uint32_t> m_viSlrc;
> /* best-effort access class retry counters */
> TracedValue<uint32_t> m_beSsrc;
> TracedValue<uint32_t> m_beSlrc;
> /* background access class retry counters */
> TracedValue<uint32_t> m_bkSsrc;
> TracedValue<uint32_t> m_bkSlrc;.
>
> May be is it better to make std::map<AccessClass, uint32_t> and call  
> traced callback at each change of each retry counter like the  
> following
> TracedCallback<AccessClass, uint32_t> m_slrcCallback; and call  
> m_slrcCallback(ac, retryCount)?
>
> Is it worth to replace this huge set of traced values (and trace  
> sources in GetTypeId) with two maps and two traced callbacks?
> It seems to me that fixed number of available access classes is not  
> good here.

Maybe the best way is to add in future other counters for the new  
access classes. The total number of possible access classes is 8; 9 if  
we consider AC_BE_NQOS access class. If this number was variable i'd  
agree with you, but in this condition i think that use of traced  
callback is tedius.

Regards,

Mirko

--
Mirko Banchi

e-mail:    mk.banchi at gmail.com
e-mail:    mk.banchi at virgilio.it
id-jabber: mk.banchi at jabber.org

PGP key fingerprint:

308F BFB1 4E67 2522 C88E
DC69 7631 52ED 32A5 6456




-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2502 bytes
Desc: not available
Url : http://mailman.isi.edu/pipermail/ns-developers/attachments/20091023/8f3de717/smime.bin