[Ns-developers] Ipv6Extension (was UDPv6, missleading subject)

[Sebastien Vincent]

Hi Tom,

Tom Henderson a écrit :
> Sébastien Vincent wrote:
>> Hi,
>>
>> I merge Fabian's repository (ns-3-ipv6-option) into ns-3-ipv6-ext 
>> repository (http://svnet.u-strasbg.fr/hg/ns-3-ipv6-ext). I also fix 
>> comments from codereview.
>
> Fabian and Sebastien,
>
> I reviewed this again tonight.  My main remaining comments are:
>
> 1) I would recommend some test code coverage for some of this 
> (particularly fragmentation).  I didn't notice any new tests added for 
> these extensions.
>

I will try to do something next week.

> 2) coding style for the new files; we indent the braces such as the 
> gnu indent program -bl or -bli2 options:
>
>                if (x > 0)
>                  {
>                    x--;
>                  }
>

Done.

> 3) when you merge, please update RELEASE_NOTES and CHANGES.html
>

OK.

--
Sebastien

> Regards,
> Tom
>