[Ns-developers] [Fwd: Requesting Review of Wifi Enhancement]

[Tom Henderson]

FYI, a new code review on ns-3-reviews list

-------- Original Message --------
Subject: Requesting Review of Wifi Enhancement
Date: Tue, 12 May 2009 16:56:03 +0200
From: Timo Bingmann <timo.bingmann at student.kit.edu>
Reply-To: ns-3-reviews at googlegroups.com
To: Mathieu Lacage <mathieu.lacage at sophia.inria.fr>
CC: ns-3-reviews at googlegroups.com


Hello Mathieu,

I've uploaded on the codereview platform a hopefully readable version of 
the first set of my wifi contributions.

http://codereview.appspot.com/65051

It contains multiple added independent features:

- Ns2ExtWifiPhy
which works exactly like ns-2's WirelessPhyExt from the DSN.

- NakagamiPropagationLossModel
Based on GammaVariable and ErlangVariable

- TrafficApplication
based on OnOffApplication but much simpler and useful for stochastic 
streams. creates packets using a factory class.

There are also many many other small non-substantial changes, which I 
made while coding, generally improving code quality or readability.

We will have to talk about the WifiPhyTag, but I suggest you look first 
at how much easier it makes function calls.

I renamed WifiStateHelper to YansWifiStateHelper, but ultimately 
refrained from splitting it up into Ns2ExtWifiStateHelper. Oh well.

Many const changes, because the other order is very uncommon.

Removing a duplicate Eifs variable.

Well. Let's use that review tool. Thanks in advance.

Greetings
Timo

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google 
Groups "ns-3-reviews" group.
To post to this group, send email to ns-3-reviews at googlegroups.com
To unsubscribe from this group, send email to 
ns-3-reviews+unsubscribe at googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/ns-3-reviews?hl=en
-~----------~----~----~----~------~----~------~--~---