[Ns-developers] Bug 557 patch review

[Mathieu Lacage]

see http://codereview.appspot.com/63048 and the associated review on
ns-3-reviews.

Mathieu

On Thu, 2009-05-07 at 19:14 +0200, Faker Moatamri wrote:
> Dear all,
> I post this patch for review. This patch actually refractors the code to 
> do what is specified in bug 
> 557:http://www.nsnam.org/bugzilla/show_bug.cgi?id=557.
> If we want to create an internet stack we can use the helper class 
> internet-stack-helper to create the different components of the internet 
> stack and to link them together. All the work done when aggregating a 
> protocol with a node that used to make it a bit complex is now hidden 
> using the Object::NotifyNewAggregate virtual function. This function is 
> implemented by the different protocols (udp,tcp,ipv4,icmp...) to 
> actually complete the aggregation between a given node and the protocol. 
> It updates all the needed fields differently for each protocol so that 
> the internet stack will be complete. It is called by the AggregateObject 
> for all the protocols connected to the node.
> I also cleaned up the code to make it more concise and removed some 
> functions like AddInternetStack and some files like internet-stack.cc/h. 
> The patch should apply very well to the current version of the 
> repository (Thursday May 7th, 19:00 GMT+1).
> If you need more precisions please don't hesitate to contact me. Any 
> reviews and comments are welcome.
> Best regards
> Faker Moatamri