[Ns-developers] osx compiler is ugly

[George Riley]

Can't we simply provide a waf command line option to
"ignore warnings" and document that this switch is to be used only if
certain older compilers are producing the erroneous warnings?
Then we don't need the "ugly" code, right?
George

--------------------------------------------------
George Riley
Associate Professor
Georgia Tech
Electrical and Computer Engineering
riley at ece.gatech.edu
404-894-4767
Klaus Advanced Computing Building
Room 3360
266 Ferst Drive
Atlanta, Georgia 30332-0765

ECE4110 Web page:
http://users.ece.gatech.edu/~riley/ece4110/

ECE4112 Web page:
http://users.ece.gatech.edu/~riley/ece4112/









On May 1, 2009, at 11:42 AM, <L.Wood at surrey.ac.uk>  
<L.Wood at surrey.ac.uk> wrote:

> Mac OS X Leopard (intel and ppc) ships with gcc 4.0.1. Later
> versions are available, but it's unlikely that users will install
> them (and they introduce their own fun, e.g. gcc 4.4 deprecating
> varargs.h in favour of stdarg.h)
>
> Really, the compiler's the least of the problems. Leopard's linker
> is generally regarded as... interesting.
>
> <http://www.ee.surrey.ac.uk/Personal/L.Wood/><L.Wood at surrey.ac.uk>
>
>
>
> -----Original Message-----
> From: ns-developers-bounces at ISI.EDU on behalf of Faker Moatamri
> Sent: Thu 2009-04-30 16:57
> To: Mathieu Lacage
> Cc: ns-developers at ISI.EDU
> Subject: Re: [Ns-developers] osx compiler is ugly
>
> Mathieu Lacage wrote:
>> hi,
>>
>> I noticed that our osx-ppc build using gcc 4.0.1 is broken and can be
>> fixed with the following patch.
>>
>> Normally, I would commit this without asking around, but, this  
>> patch is
>> so ugly and makes me feel so dirty that I have to ask: do we really  
>> want
>> to commit this ?
>>
>> diff -r fcb74b52e91b src/devices/wifi/edca-txop-n.cc
>> --- a/src/devices/wifi/edca-txop-n.cc   Thu Apr 30 14:11:58 2009  
>> +0200
>> +++ b/src/devices/wifi/edca-txop-n.cc   Thu Apr 30 07:27:59 2009  
>> -0700
>> @@ -667,6 +667,8 @@ EdcaTxopN::MapSrcAddressForAggregation (
>>     {
>>       return hdr.GetAddr3 ();
>>     }
>> +  // quiet buggy compiler
>> +  return Mac48Address ();
>> }
>>
>> Mac48Address
>> @@ -680,6 +682,8 @@ EdcaTxopN::MapDestAddressForAggregation
>>     {
>>       return hdr.GetAddr3 ();
>>     }
>> +  // quiet buggy compiler
>> +  return Mac48Address ();
>> }
>>
>> void
>>
>>
>>
> Is it possible to upgrade OSX-PPC compiler? may be a newer version  
> will
> correct this compiling error. Otherwise I think it's mandatory to  
> commit
> this ugly code if we want to support Mac with comments noticing why we
> wrote this code (for example: osx-ppc compiler gcc 4.0.1 requires this
> line to be added).
>