[Ns-developers] George's netanim changes

George Riley riley at ece.gatech.edu
Mon Mar 23 12:18:01 PDT 2009


> Although it's not a requirement for merges in src/contrib, it would be
> nice to follow the ns-3 coding style:
>
> 1) one statement per line:
> if (foo) x
> should be rewritten as:
> if (foo)
>  {
>    x
>  }
The coding standard specifically allows the single statement
"IF" statement as above.
>
>
> 2) proper indent:
> if (foo)
> {
> }
> should be:
> if (foo)
>  {
>    //
>  }
Yes, it should be indented as you say; don't know what happened there
because my emacs always indents properly.

George

>
>
>
>
> On Mon, 2009-03-23 at 14:12 -0400, Raj Bhattacharjea wrote:
>> George's initial animation code required changes to the core of ns-3
>> to support the kind of traces he needed for PointToPoint animation.
>> Since then, the trace sources have changed drastically thanks to
>> Craig's tracing rework.  So, it looks like the new trace sources
>> provide all of the information needed by George's animator to perform
>> animation.  I refactored George's tree, such that no modifications to
>> the rest of ns-3 were required:
>>
>> http://code.nsnam.org/raj/ns-3-netanim/
>>
>> Pushing this was planned for ns-3.4.  Is there any feedback on the
>> changes?  It basically provides another pcap tracing like interface
>> for making NetAnim trace files, which can be animated by George's
>> standalone animator.
>>
>



More information about the Ns-developers mailing list