[Ns-developers] 802.11s code review

[Gustavo Carneiro]

2009/3/17 Pavel Boyko <boyko at iitp.ru>

>
>  Dear Gustavo and Ruben,
>
> On Monday 16 March 2009 21:31:45 you wrote:
> > Yep, I agree too. There should be a clear distinction between what is
> > really standard compliant (i.e. defined in the standard) and what is (a)
> > inferred from the standard because it was not clearly defined in the
> > standard (b) research stuff.
>
>   Right, this is exactly what keeps us busy now, I am sorry for confusing
> you.
> After refactoring we'll have 'devices/mesh' module with a protocol
> independent
> framework for level 2 mesh and 'devices/mesh/802.11s' module implementing
> .11s
> draft protocols. Our research stuff (and this _is_ the thing we are really
> interested in :) is supposed to appear then as 'devices/mesh/foo',
> 'devices/mesh/bar', etc. modules. Is that ok?


That sounds good.

Also don't forget to rename the L2Xxx stuff to something more specific.  I
mean, for instance UMTS is L2 too, and I don't suppose your framework
applies to UMTS networks... ;-)

And, I forgot to answer one of Mathieu's questions, to share or not to share
the LearningBridge functionality.  In my humble opinion, the LearningBridge
forwarding algorithm is rather trivial to code, and is probably not worth
the trouble of refactoring to reuse it in different contexts.  In my
opinion, some times copy-paste is not evil, sometimes it simplifies things,
makes the code easier to follow because you don't have to jump so much
around into different classes/functions.

Thanks.

-- 
Gustavo J. A. M. Carneiro
INESC Porto, Telecommunications and Multimedia Unit
"The universe is always one step beyond logic." -- Frank Herbert