[Ns-developers] ns-3.4 : Final Steps

[Mathieu Lacage]

On Fri, 2009-03-13 at 11:58 -0400, Raj Bhattacharjea wrote:

> ======Tracing======
> There are 2 bugs related to tracing (443 and 505).  The main one is
> the trace source rework of bug 443.  It is queued up for merge at:
> http://code.nsnam.org/craigdo/ns-3-tracing
> This needs a little review, and I have not seen any further comments
> from others.  I will be taking a look at the changes today, and
> providing feedback to Craig.  I suspect the changes should be ready
> for merge as-is, probably Monday.  The one linger question I have is
> about bug 505, which is blocked on the rework; I am not sure we can
> converge on a solution quickly enough after the tracing work is put
> in.

I reviewed the src/devices/wifi part of the last version: there are a
couple of uneeded changes:

and wifi-net-device.h:
void SniffPacket (Ptr<const Packet> packet, Mac48Address to,
Mac48Address from, uint16_t type);

wifi-net-device.cc:
+#include "ns3/ethernet-header.h"
+#include "ns3/ethernet-trailer.h"

and, in wifi-net-device.cc: are you sure you need the copy below ?

-      m_promiscRx (this, packet, llc.GetType (), from, to, type);
+      m_promiscRx (this, packet->Copy (), llc.GetType (), from, to,
type);

Mathieu