[Ns-developers] Request to commit -fvisbility=hidden python bindings patch

[Gustavo Carneiro]

2009/3/4 Gustavo Carneiro <gjcarneiro at gmail.com>

>
>
> 2009/3/3 Raj Bhattacharjea <raj.b at gatech.edu>
>
>> On Tue, Mar 3, 2009 at 9:48 AM, Gustavo Carneiro <gjcarneiro at gmail.com>
>> wrote:
>> > Hi Raj,
>> >
>> > May I commit the patch at [1] for ns 3.4?  It decreases python bindings
>> size
>> > (from 6 to 5 MB) and decreases its loading time (didn't measure, but the
>> > documentation [2] claims it to be so...).
>> >
>> > Regards,
>> >
>> > [1] http://www.nsnam.org/bugzilla/show_bug.cgi?id=515
>> > [2] http://gcc.gnu.org/wiki/Visibility
>>
>> Do the python bindings need a rescan following this change?  I am
>> getting cryptic errors out of a fresh copy of ns-3-dev that seem to go
>> away after I run ./waf --python-scan .
>
>
> No re-scanning is needed, but the bindings .cc files need to be
> regenerated.  Unfortunately the build system does not trigger a rebuild of
> the bindings when the required pybindgen version changes.  As a work around,
> just rm -rf build/debug/bindings.  Sorry about that.
>

regression build farm showed it was a different problem.  Apparently, gcc
4.x doesn't always support -fvisibility=hidden.  Maybe it's a platform
specific flag.  In any case, should be fixed now, although I'm still waiting
for confirmation from the build farm.


>
>
> --
> Gustavo J. A. M. Carneiro
> INESC Porto, Telecommunications and Multimedia Unit
> "The universe is always one step beyond logic." -- Frank Herbert
>



-- 
Gustavo J. A. M. Carneiro
INESC Porto, Telecommunications and Multimedia Unit
"The universe is always one step beyond logic." -- Frank Herbert