[Ns-developers] Tracing Rework

[Tom Henderson]

> 
>> I can then 
>>
>> 1) Remove the objectionable Sniffer (Ethernet frame) and tx complete trace
>> sources from the wifi device;
>>
>> 2) Remove the unused rx start trace sources from the csma and point-to-point
>> devices;
>>
>> 3) Remove the non-promiscuous sniffer helper code from the wifi-helper and
>> leave yans-wifi-phy hooked to the promisc sniffer;
>>
>> 4) Write some words for the manual on this stuff.
> 
> I think that the above would be fine.

I agree with the above and with just documenting that there is a 
preferred list of trace sources for net devices but some devices only 
support a subset of the recommended sources.

For the wifi promiscuous trace, it would be helpful to document that 
what is being traced corresponds to tcpdump "monitor" mode; namely, 
control and management frames are being captured.  I think what you were 
trying to do with the ethernet header may be equivalent to the default 
"non-monitor" mode when tcpdump is run on a wireless interface.  I think 
it is fine to just support monitor mode because there is much more 
information and because wireshark and tcpdump can display these extra 
frame traces.  It would be useful to test, before you are done, that 
wireshark and tcpdump can still handle the promiscuous packet traces 
generated.

Also,
+    .AddTraceSource ("PhyTxBackoff",
+                     "Trace source indicating a packet has been delayed 
by the CSMA backoff process",
+                     MakeTraceSourceAccessor 
(&CsmaNetDevice::m_phyTxBackoffTrace))

I thought you previously agreed that this trace source should be a mac 
level source?


- Tom