[Ns-developers] [Bug 370] ipv4-interface.h is installed

[Raj Bhattacharjea]

On Mon, Mar 2, 2009 at 11:07 AM, Gustavo Carneiro <gjcarneiro at gmail.com> wrote:
>
>
> 2009/3/2 Raj Bhattacharjea <raj.b at gatech.edu>
>>
>> On Mon, Mar 2, 2009 at 10:43 AM, Gustavo Carneiro <gjcarneiro at gmail.com>
>> wrote:
>> >
>> >
>> > 2009/3/2 Raj Bhattacharjea <raj.b at gatech.edu>
>> >>
>> >> On Sat, Feb 28, 2009 at 10:04 AM, Gustavo Carneiro
>> >> <gjcarneiro at gmail.com>
>> >> wrote:
>> >> > Hi Raj, I need your permission to commit the patch to fix the P2 bug.
>> >> >
>> >>
>> >> This is a notification that Gustavo has the tree for pushing this fix.
>> >>  Everyone else please refrain from commits while Gustavo has the
>> >> token.
>> >
>> > Oh, we are dealing with "tokens" now?  I thought a DVCS was supposed to
>> > save
>> > as from this archaic nonsense of us doing work that should be done by
>> > computers... :-)
>> >
>> > Anyway, you can have your token back; I am done.
>> >
>>
>> The logic behind this is testing.  The full regression suite on
>> ns-regression takes hours to run; if others commit changes while you
>> are running the regression on your (now stale) copy of ns-3-dev, there
>> is no guarantee that a merged branch (their changes + yours) will now
>> ALSO pass the regression tests.  So you would have to pull, merge, and
>> run the test again for a few hours.  When you are done, if someone
>> else has pushed changes, you waste more hours waiting for the
>> regression test to finish.
>
> Surely running the regression tests on your own host would be enough?  I
> never run regression tests on any remote host.  It takes less than a minute
> on my laptop.
>

No.  You really should make sure you didn't break the build on the
ns-regression farm of machines.  We've certainly seen patches which
break the build on some, but not all supported architectures.

This isn't required during the "open phase" of a release, but during
this "maintenance phase" when new features won't be merged but we
aren't in a full code freeze, making sure the tree stays stable is the
best practice.

-- 
Raj Bhattacharjea
Georgia Institute of Technology
School of Electrical and Computer Engineering
Ph.D. Candidate
Systems Analyst
404.894.2955