[Ns-developers] release update [feedback needed]

[Gustavo Carneiro]

2009/6/10 Tom Henderson <tomh at tomh.org>

> Gustavo Carneiro wrote:
>
>> 2009/6/9 Gustavo Carneiro <gjcarneiro at gmail.com>
>>
>>
>>> 2009/6/9 Mathieu Lacage <mathieu.lacage at sophia.inria.fr>
>>>
>>>  hi,
>>>>
>>>> Current items still on the table for merging:
>>>>
>>>>  - the virtual net device: gustavo went through a couple of iterations
>>>> with tom, I lost track of the status of this project. Gustavo, could you
>>>> merge in today ? If not, what is holding this ?
>>>>
>>>
>>> I need to rename it again, and cleanup some comments / api docs.  However
>>> I
>>> am working on paper on a tight deadline, not sure if I will have time
>>> today.  If not today, within the next two days I should be able to handle
>>> this.
>>>
>>>
>> OK, I think this is done.  Rename done, cleanup example done,
>> clarification
>> of API docs done. I'll push to ns-3-dev tomorrow (within 24 hours from
>> now)
>> if I hear no complaints.
>>
>>
> Gustavo,
> - I thought you were going to clean up the Receive/PromiscReceive separate
> functions?


I don't understand the concern here, or what I should do.  If I remove one
of them, which one do I keep?  How can we be sure it's the right one?

  - Receive() is simpler to use and usually what we want, but does not
support simulating frames received by a bridge;

  - PromiscReceive takes more parameters, harder to use if you  want to do
something simpler, but needed for certain scenarios.


>
> - also the promisSniffer trace source?


OK.


>
> - should VirtualNetDevice::SendFrom() not succeed if m_supportsSendFrom is
> false?


I would expect VirtualNetDevice::SendFrom() to not ever be called at all if
m_supportsSendFrom is false, but I guess I can add an assertion.


>
>
> Would you like a patch tomorrow (if you are busy)?
>

I think I can handle it today.  Except the first item, which still poses
doubts.

-- 
Gustavo J. A. M. Carneiro
INESC Porto, Telecommunications and Multimedia Unit
"The universe is always one step beyond logic." -- Frank Herbert