[Ns-developers] review request for ns-3 IPv4 refactoring

[Mathieu Lacage]

On Wed, 2009-01-28 at 23:31 -0800, Tom Henderson wrote:

> >> So, it seems to me that either Olsr has to ask Ipv4 or its routing 
> >> protocol how it should insert itself (hence, the 
> >> "SupportsAddRoutingProtocol()" call), or OlsrAgent needs to be 
> >> configured by something like a helper so that it knows at runtime how it 
> >> should insert itself.
> > 
> > I really don't understand why the helper can't just create the olsr
> > routing protocol and insert it itself.
> 
> It could, if we reworked Olsr.  Presently, though, there are two 
> components, an OlsrAgent and an OlsrRoutingTable, the latter of which is 
>   the Ipv4RoutingProtocol.  I think it may have been done this way for 
> ease of porting from ns-2.

Well, we need to rework olsr then: it's a small price to pay to make the
API really solid. As I said earlier, I don't mind getting my hands dirty
once we have agreed on the desirable approach.

Mathieu