[Ns-developers] Gnuplot and Nakagami

Mathieu Lacage mathieu.lacage at sophia.inria.fr
Fri Jan 9 02:07:26 PST 2009


On Fri, 2009-01-09 at 10:57 +0100, Timo Bingmann wrote: 
> > I tried to review it again: I can't merge the random variable bits
> > because these need an ack from the relevant maintainer so I tried to
> > merge only the gnuplot+wifi changes. It would be helpful if you
> could
> > pull && merge ns-3-dev in your tree again.
> 
> Yes ok, is that Michele that needs to look over the code?

I believe so.

> > 1) a couple of changes to InterferenceHelper: I don't have anything
> > against them per-se but I don't really understand them.
> Specifically, I
> > don't really understand the point of checking the noise floor
> against
> > nan. I see what the code is doing but I wonder what you are trying
> to
> > modelize here. I did not merge this piece.
> 
> I had to add that piece of code to get a _fixed_ noise floor of, i
> believe, -99 dBm to compare results against ns-2. The better way is
> the current code: to calculate noise from thermal noise and bandwidth
> multiplied by the RxRatio. I used if isnan() instead of adding another
> boolean attribute UseConstantNoiseFloor. I'm not sure I like that
> if(isnan()) very much, but I do believe a fixed, empirical noise floor
> may be useful for other people as well.

Ah, I see. Would you care to put together a patch which uses a boolean
flag and adds a separate setter/getter ?

> > 3) I merged your new gnuplot classes and the relevant changes to the
> > examples
> 
> I reviewed both merges, they are good. You missed the doxygen.conf
> modification: added amsmath package because it is needed for some math
> formula I added; at least on my texlive installation it is needed.

done.

> > 5) I think that it would make sense to split
> propagation-loss-model.h/cc
> > in a set of files, one for each subclass. Would you care enough to
> > submit a patch for this ?
> 
> ... the usual tradeoff between code readability and compilation speed.
> Well in this case I pledge to keep the simple "one-formula"
> propagation models in one main file. Code wrapping around the formula
> is similar and therefore everything is easier to read. And the wifi
> directory is already crowded enough.

fine with me.

Mathieu



More information about the Ns-developers mailing list