[Ns-developers] [Ns-commits] craigdo/ns-3-tap

[Mathieu Lacage]

I don't really care that much but I think that we should:
1) avoid the use of these gcc-only attributes when we can
2) if we really need to, wrap them in a macro in src/core/something.h to
avoid sprinkling gcc dependencies everywhere in the code.

In this case, it seems to me that adding an if (result != size)
{NS_FATAL_ERROR} message would make sense to the first patch chunk and
the second could use Skip (2) instead of the attribute. Thus, in both
cases, we can trivially avoid the use of this fairly unportable
construct.

regards,
Mathieu

On Thu, 2009-02-05 at 12:43 -0500, code at nsnam.ece.gatech.edu wrote:
> ---- use __attribute__ ((unused))
> user: Craig Dowell <craigdo at ee.washington.edu>
> files: src/devices/tap-bridge/tap-bridge.cc src/internet-stack/arp-header.cc
> url: http://code.nsnam.org/craigdo/ns-3-tap/rev/18b802510f59
> 
> 
> _______________________________________________