[Ns-developers] Updating Python bindings in ns-3-dev

[Tom Henderson]

Gustavo Carneiro wrote:
> While trying to update Python bindings to use newer PyBindGen and rescan API
> definitions, I noticed they didn't compile.  Besides the usual couple of
> methods declared but not implemented, some now private header files need to
> be made public.  Public classes' destructors will try to invoke destructor
> of contained objects and compilation fails if those objects have incomplete
> types.
> 
> Any objections to this patch?
> 
> 

This patch and Mathieu's previous one is inconsistent about which impl 
classes need to be exported and which ones can stay private, which makes 
me wonder whether there is further cleanup or alignment needed.  For 
instance, tcp-socket-impl.h and nsc-tcp-socket-impl.h but not 
udp-socket-impl.h.  Also, the IPv4 implementation headers are largely 
exported but the IPv6 headers are not.

Mathieu didn't comment on why he needed these extra v4 headers exposed. 
  Do you have an idea, however, why tcp-socket-impl.h needs to be public 
now but udp-socket-impl.h doesn't?

- Tom