[Ns-developers] osx compiler is ugly

Mirko Banchi mk.banchi at gmail.com
Thu Apr 30 07:52:40 PDT 2009


Mathieu Lacage ha scritto:
> hi,
> 
> I noticed that our osx-ppc build using gcc 4.0.1 is broken and can be
> fixed with the following patch.

What kind of error?

> Normally, I would commit this without asking around, but, this patch is
> so ugly and makes me feel so dirty that I have to ask: do we really want
> to commit this ?

I agree. It's very ugly.

> diff -r fcb74b52e91b src/devices/wifi/edca-txop-n.cc
> --- a/src/devices/wifi/edca-txop-n.cc   Thu Apr 30 14:11:58 2009 +0200
> +++ b/src/devices/wifi/edca-txop-n.cc   Thu Apr 30 07:27:59 2009 -0700
> @@ -667,6 +667,8 @@ EdcaTxopN::MapSrcAddressForAggregation (
>      {
>        return hdr.GetAddr3 ();
>      }
> +  // quiet buggy compiler
> +  return Mac48Address ();
>  }
>  
>  Mac48Address
> @@ -680,6 +682,8 @@ EdcaTxopN::MapDestAddressForAggregation 
>      {
>        return hdr.GetAddr3 ();
>      }
> +  // quiet buggy compiler
> +  return Mac48Address ();
>  }

Mirko

-- 
Mirko Banchi

e-mail:    mk.banchi at gmail.com
e-mail:    mk.banchi at virgilio.it
id-jabber: mk.banchi at jabber.org
id-msn:    mb11684 at hotmail.com

PGP key fingerprint:

308F BFB1 4E67 2522 C88E
DC69 7631 52ED 32A5 6456

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3410 bytes
Desc: S/MIME Cryptographic Signature
Url : http://mailman.isi.edu/pipermail/ns-developers/attachments/20090430/6104faa2/smime.bin


More information about the Ns-developers mailing list