[Ns-developers] c0de review submission HOWTO

[Nicola Baldo]

Hi,

> Since I did not receive screaming emails saying that it was a horribly
> bad idea, I created http://groups.google.com/group/ns-3-reviews/, and I
> would like to suggest everyone who wants to submit a review to:
> 
> 0) download http://codereview.appspot.com/static/upload.py
> 1) record the changes you want to request a review for in a mercurial
> repository: "hg commit ..."
> 2) within the mercurial repository, run upload.py to submit a review
> with http://codereview.appspot.com/. Make sure you specify
> ns-3-reviews at googlegroups.com as a CC.

I had some trouble when submitting the radiotap code for review. In the 
repository I was working I had already pulled changes from ns-3-dev a 
couple of times. Due to limitations in upload.py, also the changesets 
pulled from ns-3-dev were published on codereview, which is of course 
not desirable.

I found the following workaround:

# assumption: DEV_BRANCH_WITH_NEW_FEATURE is in sync with ns-3-dev
hg clone http://code.nsnam.org/ns-3-dev ns-3-tmp
cd ns-3-tmp
export REVNO=`hg tip -q | sed 's/:.*$//'`
hg pull DEV_BRANCH_WITH_NEW_FEATURE
hg merge
hg commit -m "merged new feature"
upload.py --rev=$REVNO --cc=ns-3-reviews at googlegroups.com

Of course if anybody has a better solution I'd be glad to hear about it!

Regards,

Nicola