[Ns-developers] code review tool

[Mathieu Lacage]

On Fri, 2009-04-10 at 18:30 +0100, Gustavo Carneiro wrote:
> Well, this tool does not make the job any easier for submitters of
> patches, just for the reviewer.  And it does not take full advantage
>  of DVCS, for instance create a temporary branch to fix a bug,
> maintainer responds, submitter makes a new commit in the branch to fix
> the problems, and so on.
> 
> That being said, it may not make submitter's job easier, but it does
> not seem to make it noticeably harder either, so no objections from
> me.
> 
> But do we need to do this for _all_ patches, or just the medium/large
> patches?

If I _personally_ have to review some code, I would rather use this tool
than do the review by email so, I would find it really helpful if patch
submitters were willing to do this. If submitters don't do it, I will
probably end up doing it myself to write reviews for them. Writing
reviews by mail is just way too painful.

Mathieu