[Ns-developers] code review tool

[Faker Moatamri]

Mathieu Lacage wrote:
> hi,
>
> Because the number of pending code reviews is growing quickly, and email
> is a pain to deal with them, tom and I would like to get a code review
> tool up and running. A new collegue of mine, Faker looked at
> review-board.org which looks cool in a demo but is a real pain to setup
> correctly and seems to be problematic to use for our mercurial-based
> workflow. 
>
> So, I would like to suggest that we use rietveld instead. I uploaded a
> sample patch: http://codereview.appspot.com/37042
> and anyone can review it if they have a google account. If you have a
> google account, you can also post new patches for review:
> http://codereview.appspot.com/new
>
> I used the upload.py script mentioned in the webpage above to create
> this test review patch:
> hg clone http://code.nsnam.org/mathieu/ns-3-simu
> cd ns-3-simu
> # edit README
> hg ci -m "test" README
> upload.py --rev=4583
>
> The above is pretty straightforward which is why I feel it would be nice
> to pick this tool and just go ahead with actually doing code reviews :)
>
> So, I would like to propose that:
> 1) we create a google group ns-3-reviews: if you want to follow through
> email code reviews, this is where you should subscribe
> 2) we ask those who submit code for review/inclusion to submit it
> through rietveld with upload.py  (I believe that the web interface will
> not work with anything but svn repositories but I would be happy to be
> proven wrong) and make sure they CC ns-3-reviews
>
> One thing some might feel concerned about is adding a dependency on an
> externally-maintained server: I personally don't feel bad about this: we
> can always install a copy of rietveld on a server of our own if we are
> unhappy about google's handling of the corereview.appspot.com server.
>
> It would be nice to hear positive or negative comments about this
> proposal.
>
> Mathieu
>
>   
Hi all,
I completely agree with the solution proposed by Mathieu, the code 
review looks very cool and I think this will work very well for users. 
The interface is well done and the addition of a review is relatively 
straightforward.

I've been through the details of how to add a review to rietveld(this 
can be used for a small how to):
-Download the upload.py code from 
http://codereview.appspot.com/static/upload.py
-put it in you repository and change the access right: /chmod +x upload.py/
-after committing your code to your local version control using your 
preferred tool, you can use the command: /hg log -v | less/ to find the 
revision number needed (you can also use eclipse to get it)
-use the command given by Mathieu:/upload.py --rev=rev_num /where the 
revision number is the revision number from which you want to compare 
your code, in my case it was 4308
-you will get the message:
/Upload server: codereview.appspot.com (change with -s/--server)
New issue subject:
/-You enter the issue subject
-you will be asked : /Email (login for uploading to 
codereview.appspot.com):/
-you enter your google email: faker.moatamri at gmail.com
-you will be asked your password: /Password for faker.moatamri at gmail.com:
-/enter your password:/ password /(sorry can't give you my password :-) )
-you get the url of the review and the files added:
/Issue created. URL: http://codereview.appspot.com/39045
Uploading base file for utils/testfile.cc
Uploading base file for utils/mobility-visualizer-view.cc
/(Note:The above files are the files I changed)/
/-You are done, you can wait for comments now

I tried to add a new repository but actually they don't even ask for the 
type of repository which confirms that they work exclusively with svn. 
So obviously the web interface to add a review will work, as Mathieu 
said, only with svn.

Best regards
Faker