[Ns-developers] 802.11s code review

[kirillano]

Hi, All!
5 weeks ago I have published our code of 802.11s draft standart:
(http://forge.wenos.ru/hgprojects/ns3dev/).
The information about architectural structure you can see here:
(http://www.nsnam.org/wiki/index.php/Mesh)
Now the implementation of 802.11s seems reached the next milestone.

In comparsion with the first version of 802.11s in NS-3 we have changed the following:

1. We have moved all our project to src/devices/mesh and put all files related with 'pure dot11s' to dot11s namespace
2. We have renamed some classes (like "L2RoutingNetDevice" now is "MeshPointDevice")
3. We have standartized interface between MAC-layer and parts of protocols (like peer management, HWMP routing) - MeshWifiInterfaceMac class and MeshWifiInterfaceMacPlugin
4. We have standarized WifiInformationElement (but did not change existing information elements of wifi), and all dot11s information elements are inherited from this base class
5. We have tested multi-interface mesh-points (extension of dot11s) and checked, that in case of single-interface it works exactly like 'pure dot11s'.
6. To test multi-interface scenario, we have added channel switching to wifi-channel (implementation of channel switching is litte bit raw, but in static frequency pattern of network it works properly)
7. In our implementation we use PacketTags, which is not included in the main ns-3-dev repository.
Changes were taken from http://code.nsnam.org/mathieu/ns-3-tags

Could you please make a review of our code and make your opinion about it?

At this moment I have NOT IMPLEMENTED the following:
1. Airtime link metric does not take into account packet error rate, because I have no idea how to access retry counters (TracedValue<uint16_t> m_slrc) in WifiRemoteStation class. This retry counter is needed to estimate the average value of packet error rate. So, could you please give some examples of using TracedValue, because, as I think, tutorial and doxygen has unsufficient information.

Regards, Kirill.