[Ns-developers] olsr rework

[Tom Henderson]

Mathieu Lacage wrote:
> hi,
> 
> As a preparation for the ipv4 rework for next release, I did a first set
> of changes to olsr to move the call to Ipv4::AddRoutingProtocol from the
> olsr-agent-impl.cc file to olsr-helper.cc. What has changed:
> 
> 1) removed olsr::Agent
> 2) renamed olsr::AgentImpl to olsr::RoutingProtocol
> 3) made olsr::RoutingProtocol derive from Ipv4RoutingProtocol instead of
> olsr::Agent
> 

Mathieu,
I reviewed this and support merging it.

One minor nit that we may want to pick up at some point is the magic 
number in the helper (Olsr is hardcoded priority 10):

+  ipv4->AddRoutingProtocol (agent, 10);

which is consistent with the current behavior (which is also a magic 
number deeper in the code), but I think we can consider this small point 
again once we look at the final reviews for the IP routing rework.

Tom