[Ns-developers] icmp message error reporting

[Raj Bhattacharjea]

Thanks for the summary of changes.  I looked through the code in
ns-3-simu, and most of the changes look sound.  My only concern is the
mtu enforcement when a UdpSocketImpl tries to send a too large packet
(udp-socket-impl.cc:377), which, given that you wrote a thorough
explanation in the comments, you realize is a hack.  The solution
implied by your code comments is to propagate Send errors back up the
stack correctly, perhaps via return values on all the Send calls down
the stack to notify the calling layers of the result.  Is there some
hurdle to implementing this?  That said, the code isn't terrible, and
with the documentation you provided, I don't have a huge problem with
it, its just a way to force the behavior you want in terms of the
current API.  Implementing it "correctly" would break our API, and I
can hear Gustavo now...

My other question is: are you proposing to merge the entire simu
branch at this point, or just the changes to support ICMP (and the
applications that use it)?

-- 
Raj Bhattacharjea
Georgia Institute of Technology
School of Electrical and Computer Engineering
Ph.D. Candidate
Systems Analyst
404.894.2955