[Ns-developers] upcoming work on Ipv4 routing

[Mathieu Lacage]

A couple of comments:

On Tue, 2008-10-21 at 19:58 +0000, Tom Henderson wrote:

> Here is a link to the overall design approach:
> http://code.nsnam.org/tomh/ns-3-ip/raw-file/0c9f7a1e050a/README.routing.txt
> 
> There is also a file "README.routing.api" with more details about the
> API:
> http://code.nsnam.org/tomh/ns-3-ip/raw-file/0c9f7a1e050a/README.routing.api

What is the return type of this method ? I would also feel better if the
outgoing parameter (route) was the last parameter of this method.

virtual enum RouteOutput (Ptr<Ipv4Route> route, const Ipv4Header
&header, uint32_t oif) = 0;

Is it possible for a callback to be invoked more than once for one call
to this method RouteInput ?

virtual void RouteInput  (Ptr<const Packet> p,

What does rtm stand for ? Would you mind extend it ?

  // Linux inet_rtm_newroute
  bool RtmNewRoute (RoutingMessage rtm);
  // Linux inet_rtm_delroute
  bool RtmDelRoute (RoutingMessage rtm);
  // Linux inet_rtm_getroute
  Ipv4RouteList RtmGetRoute (RoutingMessage rtm);


What is the point of item 6 ? Ipv4RoutingProtocol looks like a subset of
Ipv4Routing so, I can't figure out why you want to keep it.

> 
> I plan to work on implementing this fairly aggressively through the
> rest of the week (trying to meet Craig's merge deadline) so please
> send comments if you care to review it in the meantime.  I also will
> try to coordinate with Sebastien along the way.
> 
> - Tom
> 
> 
>