[Ns-developers] icmpv4 stack for merging

[Raj Bhattacharjea]

On Fri, Oct 17, 2008 at 4:56 PM, Mathieu Lacage
<mathieu.lacage at sophia.inria.fr> wrote:
> hi,
>
> Since
> http://mailman.isi.edu/pipermail/ns-developers/2008-September/004751.html
>
> I spent a while debugging this icmp stack and running it through quite a
> lot of testing. I made a couple of changes here and there, mostly to
> avoid generating icmp messages for multicast packets to avoid icmp
> storms. So far, the code has been reasonably stable so, this is a
> request for merging to craig and raj.
>
> Two patches attached:
>  - icmp.patch contains all the changes for the src/node and
> src/internet-stack directories.
>  - icmp-application.patch contains the ping application and the example
> code.
>
> It would be helpful to review the first patch again. The second patch is
> both less risky and less intrusive.

Mod Tom's suggestions, the proposal looks fine to me.  I would like to
note that I have no problem with going ahead and merging at Craig's
convenience, as I can always revert back to an older revision, or
begin work from ns-3.2 and pull in changesets.


-- 
Raj Bhattacharjea
Georgia Institute of Technology
School of Electrical and Computer Engineering
Ph.D. Candidate
Systems Analyst
404.894.2955