[Ns-developers] wifi phy API rework

[Mathieu Lacage]

On Mon, 2008-11-17 at 21:12 -0800, craigdo at ee.washington.edu wrote:
> Hi Mathieu,
> 
> Sorry for the delay.  I keep getting interrupted.  This is the fourth time
> I've started this email; hopefully I'll finish it this time :-)
> 
> > I believe that the API is complete and the implementation 
> > reasonable so,
> > I would like to move forward with this code. i.e., reviews would be
> > welcome, especially from the helper API maintainer.
> 
> Comments:
> 
> 1) There should be an Install method that takes a Ptr<Node> for Python
> support purposes, i.e.:
> 
>   NetDeviceContainer Install (const WifiPhyHelper &phy, Ptr<Node> node)
> const;

done.

> 
> 2) I think that the semantics of the trace functionality is unclear -- i.e.,
> what is being traced.   I also think that the placement of some of the
> tracing-related helpers in the phy helper is questionable -- i.e. not really
> a phy thing.  I'm sure, though, that any expansion on these comments would

I moved them down there because they trace PHY-level events (at least,
from an implementation perspective). 

[snip]

> Other than that,
> 
> <stamp> Looks good to me </stamp>

Since I did not get any other comments, I just pushed the code to
ns-3-dev. I have not yet updated the tutorial but I do plan to do so in
time before the release. Craig: when do you want me to make sure I am
done with this ?

Mathieu