[Ns-developers] Design Review of ns-3-ipv6-1st (ns-3.3 newfeature)

[Mathieu Lacage]

On Mon, 2008-11-03 at 17:45 +0100, Sébastien Vincent wrote:
> Hello,
> 
> Tom Henderson wrote:
> > craigdo at ee.washington.edu wrote:
> >>> At this point, my main concern is that I would like to know what the
> >>> plan is to deal with the ipv4 API rework under way in tom's tree.
> >>
> >> I agree completely.  I just spoke to Tom about this.  We agree that 
> >> the approach to take is to have Tom "adopt" Sebastien's changes
> >> and merge them into his IPv4 work.  This will ensure that the two 
> >> feature sets work together consistently, and will allow reviewing
> >> them as one consistent whole (which makes reviewer's lives easier).
> >>
> >> Logistically, this seems to mean that we "withdraw" the ns-3-ipv6-1st 
> >> feature proposal and allow Tom and Sebastien to coordinate how
> >> to merge it into the IPv4 rework feature proposal.  We will then see 
> >> an IPv4, IPv6 rework feature proposal appear Real Soon Now.
> >>
> >
> > Craig, I'm going to withdraw trying to put IPv4 routing rework into 
> > ns-3.3, since there is still a lot of work to do, and it would make 
> > sense to try to deal with the IPv6 at the same time.
> >
> > I would still be in favor of merging Sebastien's first repository on 
> > Ipv6 addressing (without the routing component) for ns-3.3, and try to 
> > get the routing component done for ns-3.4.
> 
> I made some small modifications to ns-3-ipv6-1st (coding style, remove 
> Ipv6Route and things from Mathieu). I already change GetMulticast things 
> in *-net-device (using Mac48Address::GetMulticast...). The code is also 
> up-to-date with ns-3-dev.

tom, craig, and myself talked about bug 294 and MakeMulticastAddress
last friday: I believe that we agreed to rename MakeMulticastAddress to
GetMulticast to mirror GetBroadcast. Would you mind update your tree to
do this for ipv6 and attach a patch to bug 294 for ipv4 ?

Other than that, the code looks great, you have a positive ack from me
for commit.

regards,
Mathieu