[Ns-developers] Mobility Model Notifier

[Gustavo Carneiro]

2008/5/15 Joseph Kopena <tjkopena at cs.drexel.edu>:

> Hi all,
>
> I want to propose a small API change, and figured I'd elevate it off
> bugzilla [1] so Gustavo can vent at me.


Fortunately what annoys me mostly is incompatible API changes in core,
common, and simulator modules.  Other modules API changes are usually less
intrusive.


>
>
> The change is minor, it simply removes the MobilityModelNotifier
> object, a largely historical artifact, and instead moves the trace
> source directly into MobilityModel.  This has been done in [2], along
> with some other cleanup.  The main reason to discuss this is that it
> may break some people's code.  In particular, anyone registering
> custom notifier objects would have to change their approach.  Trace
> paths and other minor changes such as removing
> MobilityHelper::EnableNotifier calls would have to be made.
>
> Comments welcome.


[2] looks good, and I won't object to it.  Just one minor detail:

+    .AddTraceSource ("CourseChange",
+                     "The value of the position and/or velocity
vector changed",
+                     MakeTraceSourceAccessor (&MobilityModel::m_trace))


It's not good style to have a member with a vague name like m_trace when you
could have named it m_courseChangeTrace.  More readable, won't you agree?

-- 
Gustavo J. A. M. Carneiro
INESC Porto, Telecommunications and Multimedia Unit
"The universe is always one step beyond logic." -- Frank Herbert