[Ns-developers] Learning Bridge has been merged

[Gustavo Carneiro]

2008/7/21 Mathieu Lacage <mathieu.lacage at sophia.inria.fr>:

>
> On Mon, 2008-07-21 at 17:39 +0100, Gustavo Carneiro wrote:
>
> >
> > Unless, of course, lack of API stability is a deliberate design goal,
> > to encourage outside contributors to submit their works for merging
> > into the main NS-3, like the Linux kernel does with respect to closed
> > source drivers.  If that is the case, I just think the project should
> > just have a clear statement about the issue, so that contributors know
> > what to expect and conveniently prepare for it (e.g. by submitting
> > more code to ns-3).
>
> <personal opinion>
> Whether or not there are API changes, early merging means much less pain
> for everyone because the merging points will be smaller, will be easier
> to review, and it will be easier to make the code evolve. So, whatever
> you or anyone else is working on, talking about it early and pushing
> aggressively for merging is _the_ way to go.
>
> i.e., if you want your code merged eventually, you should be pushing for
> it aggressively and keep reminding the ns-3 maintainers about it until
> it has been properly reviewed and merged. Otherwise, the chances are
> that it will fall in the cracks.
>
> Of course, if you keep spamming ns-developers, I will get eventually
> annoyed but, right now, I am worried that patch authors seem to be so
> happy with their own local mercurial branches that they don't care
> anymore about merging and are not pushing enough for their changes when
> they make sense.
> </personal opinion>
>

I agree with you submitting code for review is the way to go, whenever
possible.

I just don't understand what other reason is there for specifically forcing
the API break you requested.  I am trying to understand.  Or rather, trying
to guess.  I really don't enjoy having to try to guess.  I know that in this
case the API does not become cleaner with pure virtual methods.  Wondering
what else could be the reason...

-- 
Gustavo J. A. M. Carneiro
INESC Porto, Telecommunications and Multimedia Unit
"The universe is always one step beyond logic." -- Frank Herbert