[Ns-developers] Learning Bridge, NetDevice API changes

[Mathieu Lacage]

hi gustavo,

Very early comments below: I will review the code more carefully in a
couple of days.

1) BridgeNetDevice::GetChannel should be implemented correctly, that is,
it should return a BridgeChannel which is created on the fly and
references the channels of the underlying devices: it is important to
implement as much as you can of the NetDevice API if it makes sense and,
in this case, it makes perfect sense to make the bridge report as
neighbors the neighbors of its underlying devices.

2) I really would like to avoid the extra cruft you have added for 'api
compatibility'. This means that:
  - we could re-use the rx callback in promisc mode
  - no need for the new Node::Register/Unregister methods you have added
  - need to add enable/disable methods for promisc mode

3) What is SupportsPromiscuousReceiveCallback used for ? When do you
envision a device which could refuse to support this mode ?


regards,
Mathieu