[Ns-developers] gsoc wrapup

[Florian Westphal]

Tom Henderson <tomh at tomh.org> wrote:
> Florian Westphal wrote:
>> Here is everything in a single patch:
>> http://www.strlen.de/cradle/ns-3-nsc-aug-22-2008.diff
>
> Florian, here are a few issues that will need to be dealt with during or 
> shortly after the merge:
>
> - the code regarding add_default_gateway() is not clean and should be added 
> to the tracker as a bug when the merge occurs, if not fixed before then

No disagreement here, but I'm not sure what the _right_ solution is.
Any ideas?

> - we need to figure out how to control, in general, the handling of 
> compilation options in our unit tests and regression suite (I already 
> mentioned this), and we need a unit test or regression test added.  For 
> instance, since the available nsc stacks are platform-dependent, I wonder 
> what we will check in regression tests (a known-good stack that works in 
> all environments, only?)

nsc doesn't change the behaviour of the ns-3 example files.
What do you want me to do?
As for the nsc stacks, the main problem is that the Linux stacks
that work on both x86 and x86_64 generate different pcap traces
depending on the host architecture (for instance, it will pick different TCP
source ports on x86 vs. _64).

> - some doxygen is missing (e.g., InternetStackHelper::SetTcpDefault())

See my reply to Raj, i think that method should go.
I'll walk through things again and will try to add missing docs for any
methods i have added.

> - it would help to have a chapter in the manual and some words in the 
> tutorial about NSC.  The "README.nsc" should migrate somewhere else.

Where exactly should README.nsc go? Should it move to the wiki instead?
I could try to move contents from the ns-3-nsc wiki page to the manual,
if that is deemed acceptable. 

> - please remember to modify CHANGES.html and RELEASE_NOTES when you merge.

Will do, thanks.
Regards, Florian