[Ns-developers] gsoc wrapup

[Florian Westphal]

Raj Bhattacharjea <raj.b at gatech.edu> wrote:
> It does, and it looks good.  Nothing is a blocker here, but here are
> the few small things I see that should be added soon after merging.
> 
> InternetStackHelper::SetTcpDefaultType needs documentation.

Hrm, i'm more inclined to remove that method.
Its equivalent to 'SetNscStack("")'. The idea was that there
should be a method to essentially 'disable' NSC and have
the internet stack helper assign the ns-3s TCP model again, like this:

InternetStackHelper internet;
internet.SetNscStack("liblinux2.6.18.so");
internet.Install (nscNodes); // this creates nsc nodes
internet.SetNscStack("");
internet.Install (ns3TcpNodes); // this creates 'normal' ns-3 nodes

> The two new examples need to have the modeline, gpl, and scenario
> description block at the top.
> It would be nice if the examples had really copious comments
> describing what every few lines was accomplishing.

http://code.nsnam.org/fw/ns-3-nsc/rev/3b139bbd751b
http://code.nsnam.org/fw/ns-3-nsc/rev/ddcbdad7b407

Thanks for reviewing,
       Florian