[Ns-developers] gsoc wrapup

[Tom Henderson]

Florian Westphal wrote:
> Tom Henderson <tomh at tomh.org> wrote:
>> Mathieu Lacage wrote:
>>> On Sun, 2008-08-17 at 12:34 +0200, Florian Westphal wrote:
>>> I did a final review of the code and sent you a couple of comments
>>> privately by email. Modulo a couple of very minor details, the code
>>> looks good for merging to me so, feel free to try to push to ns-3-dev
>>> when you are ready.
>> It would be nice to try to resolve (or log into the tracker) the issues 
>> quickly if possible so that it could be merged next week.  Raj, can you 
>> please review as well?
> 
> Here is everything in a single patch:
> http://www.strlen.de/cradle/ns-3-nsc-aug-22-2008.diff
> 

Florian, here are a few issues that will need to be dealt with during or 
shortly after the merge:

- the code regarding add_default_gateway() is not clean and should be 
added to the tracker as a bug when the merge occurs, if not fixed before 
then

- we need to figure out how to control, in general, the handling of 
compilation options in our unit tests and regression suite (I already 
mentioned this), and we need a unit test or regression test added.  For 
instance, since the available nsc stacks are platform-dependent, I 
wonder what we will check in regression tests (a known-good stack that 
works in all environments, only?)

- some doxygen is missing (e.g., InternetStackHelper::SetTcpDefault())

- it would help to have a chapter in the manual and some words in the 
tutorial about NSC.  The "README.nsc" should migrate somewhere else.

- please remember to modify CHANGES.html and RELEASE_NOTES when you merge.

Otherwise, looks good to me.  Nice job on this project.

Tom