[Ns-developers] gsoc wrapup
Raj Bhattacharjea
raj.b at gatech.edu
Wed Aug 27 14:20:42 PDT 2008
On Fri, Aug 22, 2008 at 4:36 PM, Florian Westphal <fw at strlen.de> wrote:
>
> Here is everything in a single patch:
> http://www.strlen.de/cradle/ns-3-nsc-aug-22-2008.diff
>
> It should apply cleanly to current ns-3-dev tip.
It does, and it looks good. Nothing is a blocker here, but here are
the few small things I see that should be added soon after merging.
InternetStackHelper::SetTcpDefaultType needs documentation.
The two new examples need to have the modeline, gpl, and scenario
description block at the top.
It would be nice if the examples had really copious comments
describing what every few lines was accomplishing.
Maybe you should add your name to the author's list as well for the
files that you significantly touched, but I'm not sure about the rules
on this.
Thanks Florian for all your hard work on NSC over the summer.
--
Raj Bhattacharjea
Georgia Institute of Technology
School of Electrical and Computer Engineering
Ph.D. Candidate
Systems Analyst
404.894.2955
More information about the Ns-developers
mailing list