[Ns-developers] [bug] Differentiated Services module - RED algorithm

[Lengyel Miklós]

Hi all!

 

I think there is a bug in the DiffServ module of ns (version 2.32), namely
in the implemetation of the RED algorithm. In my opinion the wrong line is
in file diffserv/dsredq.cc line number 239 in function redQueue::enque :

"return PKT_DROPPED;"

This is the case when the RED drops a packet because the average queue is
greater than the max. threshold. I think the above line should be "return
PKT_EDROPPED;" because PKT_DROPPED should happen only when the link drops a
packet. When the RED algorithm drops a packet it should be early drop
(PKT_EDROPPED).

Please let me know if I am right or not.

 

Regards,

Miklos Lengyel