[Ns-developers] packet socket tree

[Tom Henderson]

Mathieu Lacage wrote:
> On Sun, 2007-08-05 at 23:41 -0700, Tom Henderson wrote:
> 
>>> Right now, this code is decently solid so, I think it is ready for a
>>> merge. Once it is merged, I would like to finish for the release the
>>> other socket API items outlined in the "issues left" section below.
>>> Comments ?
>> I've looked at the APIs and example and agree that it looks good to 
>> check in, but I prefer the implicit conversion in ns-3-address changeset 
>> 1021.
> 
> changeset 1021 is the changeset which contains the bi-directional
> conversions. Are you sure that this is what you want ? I would have
> expected that 1022 would be a more likely candidate for inclusion since
> it avoids the bidirectional conversion and settles for a single-way
> automatic conversion to Address.
> 
> I have merged the packet socket code without any implicit conversion and
> I will wait for an answer to the above question before merging implicit
> conversion.


I was responding to your previous post where you suggested looking at 
1021 in ns-3-address.  In any case, what I was specifically responding 
to was
1)   ooff = Create<OnOffApplication> (
     n3,
     InetSocketAddress (Ipv4Address("10.1.2.1"), 80).ConvertTo (),

vs.
2)   ooff = Create<OnOffApplication> (
     n3,
     InetSocketAddress ("10.1.2.1", 80),

where 2) seems nicer on the users.

> 
>>> Issues left:
>>>   - can remove Ipv4Impl
>>>   - can rename ArpL3Protocol to Arp ?
>>>   - can rename Ipv4L3Protocol to something else ?
> 
> Shall I proceed with all 3 items above ? If so, what should
> Ipv4L3Protocol be renamed to ? Ipv4Impl ? My brain does not seem to be
> able to pick a better name this morning. Or maybe we can punt all 3
> items and file bugs about them.
> 

Gustavo has previously suggested that the Ipv4 class decomposition needs 
more work.  I would suggest to log this as an open issue for the moment. 
  One possibility is to rename ArpL3Protocol to Arp, existing 
Ipv4L3Protocol to Ipv4, and change the existing Ipv4 in src/node to 
something else.

Tom