[Ns-developers] cvs build warnings

[Mathieu Lacage]

hi,

The attached patch commited 2005/09/21 21:40:35 broke the build with -
Werror because of a new compiler warning. It is annoying because it:

  - reverted one of my earlier patches to fix compiler warnings.

  - comments out a bunch of code adding a comment that the code is dead.
If it is dead, please, kill the code. Otherwise, the code gets even more
unreadable than it already is: the cvs history can get it back to you.

  - changes the format of energy tracing. Although I don't care much
about this myself, it looks quite un-nice to do this to those who use
it. Or maybe there are no users ?

I have checked in this patch to fix the compiler warnings. Please, can
the author of that patch take care of removing the dead code introduced
in cmu-trace.cc ?

Index: trace/cmu-trace.cc
===================================================================
RCS file: /nfs/jade/vint/CVSROOT/ns-2/trace/cmu-trace.cc,v
retrieving revision 1.86
diff -r1.86 cmu-trace.cc
693a694,698
>               default:
>                       // quiet compiler
>                       cChunkType = ' ';
>                       assert (false);
>                       break;



regards,
Mathieu
--