[Ns-bugs] [Bug 1296] Enhancement in Internet module
code at nsnam.ece.gatech.edu
Wed Mar 14 17:25:03 PDT 2012
--- Comment #2 from Tommaso Pecorella <tommaso.pecorella at unifi.it> 2012-03-14 20:25:03 EDT ---
This contains two separate enhancements: one (print metric infos) is going to
be patched soon by
The other one is a GetRouting helper function. I don't have anything against
this one, but please make one similar for IPv6.
The only drawback I see, tho, is that the helper function needs to include the
listrouting. Not a biggie tho.
There are two other "minor" things included there:
1) a change that seems more like an optimization rather than anything else, and
2) a change from private to protected of a bunch of member variables in
I don't mind the optimization, but I *do* mind the change from private to
+1 for the GetRouting Helper function, but do it for IPv6 as well please.
+1 for the optimization in Ipv4StaticRouting::PrintRoutingTable (as above,
check if the v6 one can be optimized as well).
-1 for the private to protected
Last but not least: do two separate commits, don't mix optimizations with new
Configure bugmail: https://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Ns-bugs