[Ns-bugs] [Bug 1296] Enhancement in Internet module

[code@nsnam.ece.gatech.edu]

https://www.nsnam.org/bugzilla/show_bug.cgi?id=1296

--- Comment #2 from Tommaso Pecorella <tommaso.pecorella at unifi.it> 2012-03-14 20:25:03 EDT ---
About https://bitbucket.org/cawka/ns-3-dev/changeset/f6efe075519f

This contains two separate enhancements: one (print metric infos) is going to 
be patched soon by
http://codereview.appspot.com/5784068/

The other one is a GetRouting helper function. I don't have anything against 
this one, but please make one similar for IPv6.
The only drawback I see, tho, is that the helper function needs to include the 
listrouting. Not a biggie tho.

There are two other "minor" things included there: 
1) a change that seems more like an optimization rather than anything else, and 
2) a change from private to protected of a bunch of member variables in 
IPv4StaticRouting.

I don't mind the optimization, but I *do* mind the change from private to 
protected.

Summarizing:
+1 for the GetRouting Helper function, but do it for IPv6 as well please.
+1 for the optimization in Ipv4StaticRouting::PrintRoutingTable (as above, 
check if the v6 one can be optimized as well).
-1 for the private to protected

Last but not least: do two separate commits, don't mix optimizations with new 
APIs.

-- 
Configure bugmail: https://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.