[Ns-bugs] [Bug 1170] Formulate best practices for dealing with unused debug variables

[code@nsnam.ece.gatech.edu]

https://www.nsnam.org/bugzilla/show_bug.cgi?id=1170

--- Comment #40 from Andrey Mazo <mazo at iitp.ru> 2012-02-13 05:06:09 EST ---
(In reply to comment #39)
> (In reply to comment #38)
> > Created attachment 1332 [details]
> > Updated (2nd time) patch to address Mathieu's comments.
> > 
> > Mathieu, I mostly agree with your comments and have tried to address them.
> 
> Oops, I guess, I've missed
> src/topology-read/model/rocketfuel-topology-reader.cc while making Print*
> functions return a string.
> I'll fix this later today.

I've taken a look into this and have decided to leave that piece of code as in
the latest patch (making PrintNodeInfo () return a string triggers compiler
warnings).

Mathieu supports merging this patch (he told me that he could not comment on
the bugzilla on Friday for some reason).

So unless there are any other objections, I'll push this patch today evening.

-- 
Configure bugmail: https://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.