[Ns-bugs] [Bug 1351] TCP not able to take RTT samples on long delay network

[code@nsnam.ece.gatech.edu]

https://www.nsnam.org/bugzilla/show_bug.cgi?id=1351

--- Comment #4 from Tom Henderson <tomh at tomh.org> 2012-02-03 01:17:59 EST ---
By the way, is anyone sure that this method works as expected?

void RttMeanDeviation::Measurement (Time m)
{
  if (nSamples)
    { // Not first
      int64x64_t err = m - est;
      est = est + gain * err;         // estimated rtt
      variance = variance + gain * (Abs (err) - variance); // variance of rtt


err is int64x64_t, m is Time, est is Time, gain is double.  Can a double
multiply a Time?  why not make err a Time?

A good unit test of this method is probably needed...

-- 
Configure bugmail: https://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.