[Ns-bugs] [Bug 1192] Some test cases fail to clean up properly (missing DoTeardown)

code@nsnam.ece.gatech.edu code at nsnam.ece.gatech.edu
Mon Aug 1 06:23:17 PDT 2011


https://www.nsnam.org/bugzilla/show_bug.cgi?id=1192

--- Comment #20 from Tom Henderson <tomh at tomh.org> 2011-08-01 09:23:15 EDT ---
(In reply to comment #19)
> (In reply to comment #18)
> > One small concern that I have is that the values restored in
> > TestCase::DoTeardown may be hard to maintain, in case the upstream default
> > values change.  I'm wondering whether a safer approach would be to just cache
> > the current defaults when in DoSetup state so that they can be restored in
> > DoTeardown.  
> 
> That's exactly what the last patch does.

I was looking at this part of the patch (for example):
https://www.nsnam.org/bugzilla/attachment.cgi?id=1202&action=diff#a/src/energy/test/basic-energy-model-test.cc_sec3

maybe the current patch doesn't uniformly apply Config::Reset()?  (I see it
elsewhere in the patch, though)

-- 
Configure bugmail: https://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the Ns-bugs mailing list