[Ns-bugs] [Bug 407] OLSR is missing HNA support
code at nsnam.ece.gatech.edu
Mon Mar 8 10:00:02 PST 2010
--- Comment #31 from Gustavo J. A. M. Carneiro <gjcarneiro at gmail.com> 2010-03-08 13:00:02 EDT ---
You should not call a member variable HnaRoutingTable. You know this, right?
It should be m_hnaRoutingTable. Tom is right, Object instances should always
be handled via Ptr smart pointer, never allocated directly like this.
I don't get the logic of ProcessHna()/SendHna(). SendHna sends the HNA entries
stored in m_state. ProcessHna() reads entries from a HNA message and stores
them in m_state. In the next timeout, a node will advertise HNA messages that
it received from another node as its own. This is wrong. HNA messages from
other nodes are forwarded intact using the default forwarding algorithm (in
fact, they are already). Excuse me if I read the source code wrong.
I see no implementation of AddRoutingTableAssociation, only the method
declared. I was expecting that AddRoutingTableAssociation would store the
pointer to the Ipv4StaticRouting internally. Then SendHna would grab the
routing table entries from there, excluding entries that mention excluded
Also keep in mind not to use underscored_variable_names. I know there are some
already in OLSR, but it's just that I missed them when converting the code from
the NS-2 patch.
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Ns-bugs