[Ns-bugs] [Bug 949] Node::NonPromiscReceiveFromDevice reports a meaningless destination address to user callbacks

[code@nsnam.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=949


Tom Henderson <tomh at tomh.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomh at tomh.org




--- Comment #3 from Tom Henderson <tomh at tomh.org>  2010-06-23 10:10:05 EDT ---

(In reply to comment #1)
> The non-defined value is documented:
> 
>    * \param receiver the address of the receiver; Note: this value is
>    *                 only valid for promiscuous mode protocol
>    *                 handlers.
> 
> Changing 'receiver' to the value device->GetAddress() could be incorrect.  For
> instance, broadcast or multicast packets will still be received in
> non-promiscuous mode, but the destination address will not be the unicast
> address of the interface.

In WiFi and Csma, this is set to the destination address of the L2 frame.  For
PointToPoint, we don't really have a L2 destination address conceptually.  I
would be OK with Mathieu's proposal to change this from "from" to
"device->GetAddress()" (seems to be possibly less misleading to an unsuspecting
user) and suggest to change the doxygen to:

    * \param receiver the destination address of the received frame; Note: this
value is
    *                 only valid for promiscuous mode protocol
    *                 handlers.  Note2:  If the L2 protocol does not use L2
addresses, the address reported here is the value of device->GetAddress().

-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.