[Ns-bugs] [Bug 787] Addition of Two Ray Ground model to propagation loss model and tests

[code@nsnam.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=787


Pavel Boyko <boyko at iitp.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |boyko at iitp.ru




--- Comment #2 from Pavel Boyko <boyko at iitp.ru>  2010-01-13 06:33:13 EDT ---
  Tom, 

(In reply to comment #0)
> I have ported the Two Ray Ground model from the NS-2 code into NS-3.  It seemed
> suitable to add this to the propagation-loss-model code rather than it's own
> entity.
> 
> I've also created the test case, similar to Friis, and have checked the results
> pass on OSX and Linux.
> 
> Please could any users let me know if they find any problems or issues.

  Thank you for 2-ray ground model implementation & test. All formulas are
correct to me, although number of multiplications can be optimized. The only
important thing I don't like is that you have implemented TX and RX antenna
heights as path loss model parameters. This is bad approach since every station
potentially has it's own antenna height but there is always just single
propagation loss model instance per radio channel (= ever). I propose to 
assume that every node has single antenna and use node's z coordinate as
antenna height relative to some global reference "ground level" z_0 where z_0
is an attribute of TwoRayGroundPropagationLossModel. What do you think? 

  Also please remove extra indent after namespace ns3 { to minimize diff.

-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.