[Ns-bugs] [Bug 738] CsmaNetDevice calls ReceiveErrorModel too late

[code@nsnam.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=738


Tom Henderson <tomh at tomh.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomh at tomh.org




--- Comment #2 from Tom Henderson <tomh at tomh.org>  2009-11-16 10:18:36 EDT ---
(In reply to comment #1)
> Created an attachment (id=653)
 --> (http://www.nsnam.org/bugzilla/attachment.cgi?id=653) [details]
> patch to fix the bug
> 
> This is a small patch to fix the bug. Not sure it's the most beautiful
> solution, especially with the duplicated header/trailer removal in both
> branches, but it changes as little as possible of the code. If this is not
> acceptable, I can rewrite the section slightly more to eliminate the
> duplication.
> Patched code compiles, and in my testing setup, the PER now seems to match the
> expected rate.


I agree that this bug needs fixed.  It pointed out another problem, too, which
is that the m_phyRxDropTrace inconsistently gets a packet with an Ethernet
header in one call above this code block, and without the header in the error
model call.

Attached is a patch which fixes also the drop trace issue, and removes the long
else clause.

-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.