[Ns-bugs] [Bug 526] New: PointToPointNetDevice::PhyTxBegin upcalls with an empty packet

[code@nsnam.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=526

           Summary: PointToPointNetDevice::PhyTxBegin upcalls with an empty
                    packet
           Product: ns-3
           Version: ns-3-dev
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P1
         Component: devices
        AssignedTo: craigdo at ee.washington.edu
        ReportedBy: raj.b at gatech.edu
                CC: ns-bugs at isi.edu
   Estimated Hours: 0.0


bool
PointToPointNetDevice::TransmitStart (Ptr<Packet> p)
{
  NS_LOG_FUNCTION (this << p);
  NS_LOG_LOGIC ("UID is " << p->GetUid () << ")");

  //
  // This function is called to start the process of transmitting a packet.
  // We need to tell the channel that we've started wiggling the wire and
  // schedule an event that will be executed when the transmission is complete.
  //
  NS_ASSERT_MSG(m_txMachineState == READY, "Must be READY to transmit");
  m_txMachineState = BUSY;
  m_phyTxBeginTrace (m_currentPkt);
  m_currentPkt = p;



It seems to me that the order of those last two lines needs to be switched,
else the upcall is made with nonsense or with a null packet pointer.  Craig?


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.